[Freeipa-devel] [PATCH] Fix raising nonexistent errros.NotImplemented

[Rob Crittenden]

John Dennis wrote:
> The correct exception is the built-in NotImplemented exception
> ---
> From: John Dennis <jdennis at redhat.com>
> Subject: [PATCH] Fix raising nonexistent errros.NotImplemented
> 
> 
>  0 files changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/ipaserver/plugins/rabase.py b/ipaserver/plugins/rabase.py
> index 3fc0ec5..59f0ea8 100644
> --- a/ipaserver/plugins/rabase.py
> +++ b/ipaserver/plugins/rabase.py
> @@ -58,7 +58,7 @@ class rabase(Backend):
>  
>          :param request_id: request ID
>          """
> -        raise errors.NotImplementedError(name='%s.check_request_status' % self.name)
> +        raise NotImplementedError('%s.check_request_status' % self.name)
>  
>      def get_certificate(self, serial_number=None):
>          """
> @@ -66,7 +66,7 @@ class rabase(Backend):
>  
>          :param serial_number: certificate serial number
>          """
> -        raise errors.NotImplementedError(name='%s.check_request_status' % self.name)
> +        raise NotImplementedError('%s.check_request_status' % self.name)
>  
>      def request_certificate(self, csr, request_type='pkcs10'):
>          """
> @@ -75,7 +75,7 @@ class rabase(Backend):
>          :param csr: The certificate signing request.
>          :param request_type: The request type (defaults to ``'pkcs10'``).
>          """
> -        raise errors.NotImplementedError(name='%s.check_request_status' % self.name)
> +        raise NotImplementedError('%s.check_request_status' % self.name)
>  
>      def revoke_certificate(self, serial_number, revocation_reason=0):
>          """
> @@ -101,7 +101,7 @@ class rabase(Backend):
>          :param serial_number: Certificate serial number.
>          :param revocation_reason: Integer code of revocation reason.
>          """
> -        raise errors.NotImplementedError(name='%s.check_request_status' % self.name)
> +        raise NotImplementedError('%s.check_request_status' % self.name)
>  
>      def take_certificate_off_hold(self, serial_number):
>          """
> @@ -109,5 +109,5 @@ class rabase(Backend):
>  
>          :param serial_number: Certificate serial number.
>          """
> -        raise errors.NotImplementedError('%s.check_request_status' % self.name)
> +        raise NotImplementedError('%s.check_request_status' % self.name)

This will go to the client as an Internal Error. Is this what we want?

I must've forgotten to include errors.py when I created the original 
patch for this. I created a new error class for this but it is lost now.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20091120/99202c8b/attachment.bin>