[Freeipa-devel] Re: [PATCH] Add HBAC plugin and introduce GeneralizedTime parameter type.

[Rob Crittenden]

Pavel Zuna wrote:
> Rob Crittenden wrote:
>> Pavel Zuna wrote:
>>> Sumit noticed, that the HBAC plugin didn't make it into the tree and 
>>> the patch got lost in the depths of freeipa-devel.
>>>
>>> I reworked the plugin to meet the current standards and changed 
>>> GeneraliSedTime to GeneraliZedTime. For now, I put the new parameter 
>>> type into a separate file in ipalib/plugins/generalizedtime.py. When 
>>> it's tested enough, we're going to move it to ipalib/parameters.py.
>>>
>>> The patch also modifies bootstrap-template.ldif to create a cn=hbac 
>>> container after installing IPA.
>>>
>>> Pavel
>>
>> Shouldn't GeneralizedTime be in ipalib?
>>
>> I think GeneralizedTime should have some unit tests, same for hbac.
>>
>> rob
> 
> Update:
> - Now includes extensive unit test for HBAC plugin.
> - GeneralizedTime was moved to ipalib/parameters.
> - Minor updated to HBAC plugin, mostly esthetics.
> 
> Pavel

pushed to master.

It would be nice if GeneralizedTime had its own unit tests but I don't 
want that to hold up this patch.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3245 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20091005/edace9f3/attachment.bin>