[Freeipa-devel] [PATCH] admiyo-0001-hash-params

[Adam Young]

On 08/18/2010 08:35 AM, Pavel Zuna wrote:
> On 08/17/2010 11:48 PM, Adam Young wrote:
>> On 08/17/2010 09:23 AM, Pavel Zuna wrote:
>>> On 08/12/2010 08:36 PM, Adam Young wrote:
>>>> I'll try to use a patch naming structure similar to what Pavel's 
>>>> using:
>>>>
>>>>
>>>> This patch fixes https://fedorahosted.org/freeipa/ticket/135.
>>>>
>>>> Instead of HTML Params starting with '?' we use the Hash '#' as the
>>>> startgin point. This keeps the broswer from sending addition http
>>>> requests to the server whenever we need to update the URL.
>>>>
>>> Sorry for a late review. I can't get this patch to apply, probably
>>> because of some other patches that were pushed in between. Please add
>>> me to CC on your patches, so they end up in my Inbox and I'll make
>>> sure to review them faster.
>>>
>>> Pavel
>>
>>
>> Here is an updated version. It applies on top of the pzuna patches that
>> were pushed earlier.
>>
>
> There are some trailing white spaces and you forgot to remove 
> user-details.inc from install/static/Makefile.am (doesn't build).
>
> I tried it out in my browser and it's literally 10 times faster than 
> before. Very nice. Let's hope that using # won't have any serious side 
> effects.
>
> auto-ACK when you fix those minor things.
>
> Pavel

I found a couple other things as well, so I'll resubmit the patch once 
it is done.  Good catch on the .inc file, I should have caught that.