[Freeipa-devel] [PATCH] admiyo-freeipa-0015 hashchange
Pavel Zůna
pzuna at redhat.com
Wed Aug 25 11:39:50 UTC 2010
On 2010-08-24 23:57, Adam Young wrote:
> This is a fairly substantial patch that makes use of the hashchange
> event to drive the site. It affcets just about all places where click
> events are triggered.
>
Just started reviewing the patch a few moments ago. Just 2 notes in advance:
1) It doesn't apply after the <script> eng tag patch, that was ACKed,
but not pushed yet.
2) I don't want to sound like a nitpicker, but you should do some
tweaking to your text editor. It seems to leave trailing white spaces
and more importantly, it converts 8 spaces to tabs!
The only edits in details.js are the tab conversions, so there should be
no conflict with my details patch when you remove them.
Pavel
More information about the Freeipa-devel
mailing list