[Freeipa-devel] [PATCH] 633 add selfservice aci plugin

[Adam Young]

On 12/08/2010 01:34 PM, Rob Crittenden wrote:
> Adam Young wrote:
>> On 12/08/2010 12:48 PM, Adam Young wrote:
>>> On 12/08/2010 11:02 AM, Rob Crittenden wrote:
>>>> Adam Young wrote:
>>>>> On 12/07/2010 10:54 PM, Rob Crittenden wrote:
>>>>>> Adam Young wrote:
>>>>>>> On 12/07/2010 04:33 PM, Rob Crittenden wrote:
>>>>>>>> Add plugin for manage self-service ACIs
>>>>>>>>
>>>>>>>> This is just a thin wrapper around the aci plugin, controlling 
>>>>>>>> what
>>>>>>>> types of ACIs can be added.
>>>>>>>>
>>>>>>>> Right now only ACIs in the basedn can be managed with this plugin.
>>>>>>>>
>>>>>>>> I've got an e-mail into the UI folks to see if we can enhance
>>>>>>>> this and
>>>>>>>> ask the type of object we're creating a selfservice entry for. 
>>>>>>>> This
>>>>>>>> way we can put the aci into the proper container.
>>>>>>>>
>>>>>>>> Otherwise I'm going to need to follow up to this and move a
>>>>>>>> couple of
>>>>>>>> self-service ACI's that are now in containers into the basedn.
>>>>>>>>
>>>>>>>> ticket 531
>>>>>>>>
>>>>>>>> rob
>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Freeipa-devel mailing list
>>>>>>>> Freeipa-devel at redhat.com
>>>>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>>> Probably related to the failure above, after that, doin ipa
>>>>>>> permission-find gave an error with the following in the log:
>>>>>>>
>>>>>>>
>>>>>>> Sun Dec 05 20:09:51 2010] [error] ipa: ERROR: non-public: 
>>>>>>> TypeError:
>>>>>>> tuple indices must be integers, not str
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] Traceback (most recent call 
>>>>>>> last):
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] File
>>>>>>> "/usr/lib/python2.6/site-packages/ipaserver/rpcserver.py", line
>>>>>>> 211, in
>>>>>>> wsgi_execute
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] result = 
>>>>>>> self.Command[name](*args,
>>>>>>> **options)
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] File
>>>>>>> "/usr/lib/python2.6/site-packages/ipalib/frontend.py", line 417, in
>>>>>>> __call__
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] ret = self.run(*args, **options)
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] File
>>>>>>> "/usr/lib/python2.6/site-packages/ipalib/frontend.py", line 690,
>>>>>>> in run
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] return self.execute(*args,
>>>>>>> **options)
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] File
>>>>>>> "/usr/lib/python2.6/site-packages/ipalib/plugins/baseldap.py", line
>>>>>>> 1228, in execute
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] more = callback(ldap, entries,
>>>>>>> truncated, *args, **options)
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] File
>>>>>>> "/usr/lib/python2.6/site-packages/ipalib/plugins/permission.py", 
>>>>>>> line
>>>>>>> 313, in post_callback
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] if aci['permission'] ==
>>>>>>> entry['cn']:
>>>>>>> [Sun Dec 05 20:09:51 2010] [error] TypeError: tuple indices must be
>>>>>>> integers, not str
>>>>>>
>>>>>> This would be a separate problem, can you file a ticket on it?
>>>>>>
>>>>>> rob
>>>>>
>>>>>
>>>>> Well, it happened after I applied the patch, so I think it is 
>>>>> probably
>>>>> due to the selfservice patch. Is it really a new issue, or is it a
>>>>> regression that shouldn't have been introduced?
>>>>>
>>>>>
>>>>
>>>> Ok, not sure how my patch affected this but here is an updated patch
>>>> with it fixed.
>>>>
>>>> rob
>>>
>>> So far so good, but it still has the issue with the perms being
>>> displayed Base64.
>>
>> Note that this is only on what is shown back the the user after they
>> execute the command and are prompted for the permissions
>
> Updated patch attached

ACK.  Pushed to master

>
> rob