[Freeipa-devel] [PATCH] Refactoring of baseldap callback invokation

[Jan Zelený]

Jan Zeleny <jzeleny at redhat.com> wrote:
> Jan Zeleny <jzeleny at redhat.com> wrote:
> > Adam Young <ayoung at redhat.com> wrote:
> > > On 11/29/2010 05:28 AM, Jan Zelený wrote:
> > > > This patch modifies how PRE, POST and EXC callbacks are invoked in
> > > > baseldap module. It provides method invoke_callbacks which can be
> > > > used in all classes derived from baseldap classes as well.
> > > > 
> > > > Pavel, since you originally wrote the baseldap module, I'd be
> > > > grateful if you could review the patch, since you know the best if
> > > > it covers all callback processing possibilities.
> > > 
> > > Pavel, can you take a look at this one.  I want to ACK, but after the
> > > last one I looked at like this had unintended consequences, I'm a
> > > little wary.
> > 
> > Pavel,
> > after our discussion I send a patch rebased against current master with
> > your patch 42 applied.
> > 
> > Jan
> 
> Solving another ticket, I found out that this patch caused some
> regressions. I'm sending corrected one.

Another correction - the patch now covers some new callback invokation cases. 
Also some more regressions are fixed.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-freeipa-0010-04-Refactoring-of-baseldap-callback-invokation.patch
Type: text/x-patch
Size: 19830 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101214/7e35de0b/attachment.bin>