[Freeipa-devel] [PATCH] Modified ipa help behavior

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/09/2010 09:54 AM, Jan Zelený wrote:
> Jan Zelený <jzeleny at redhat.com> wrote:
>> Jan Zelený <jzeleny at redhat.com> wrote:
>>> Now each plugin can define its topic as a 2-tuple, where the first
>>> item is the name of topic it belongs to and the second item is
>>> a description of such topic. Topic descriptions must be the same
>>> for all modules belonging to the topic.
>>>
>>> By using this topics, it is possible to group plugins as we see fit.
>>> When asking for help for a particular topic, help for all modules
>>> in given topic is written.
>>>
>>> ipa help - show all topics (until now it showed all plugins)
>>> ipa help <topic> - show details to given topic
>>>
>>> https://fedorahosted.org/freeipa/ticket/410
>>
>> So here it is: I'm sending couple patches which resolve the ticket and
>> implement grouping the way we previously discussed. Please feel free to
>> send me any recommendations if anything should be modified.
> 
> Here's updated version of 0014 (changed type detection from type(var) is 
> type({}) to type(var) is dict)
> 
> Jan

The first patch in the series does not apply cleanly anymore, can you
rebase?

Also, ipa help gives me a traceback now:

ipa: ERROR: UnboundLocalError: local variable 'mod_name' referenced
before assignment
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/ipalib/cli.py", line 1049, in run
    api.finalize()
  File "/usr/lib/python2.7/site-packages/ipalib/plugable.py", line 615,
in finalize
    p.instance.finalize()
  File "/usr/lib/python2.7/site-packages/ipalib/cli.py", line 662, in
finalize
    self._count_topic_mcl(topic_name, mod_name)
UnboundLocalError: local variable 'mod_name' referenced before assignment
ipa: ERROR: an internal error has occurred
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0PLA8ACgkQHsardTLnvCWgIwCeIlMoGGZhbmr0t9aD19L4pBHP
rf4AoNrX+TkHlSDfT0BmR3J1MEz7bU5+
=XzUE
-----END PGP SIGNATURE-----