[Freeipa-devel] [PATCH] 0033 Add disconnect command to change topology

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/21/2010 03:10 PM, Jakub Hrozek wrote:
> On 12/20/2010 09:04 PM, Simo Sorce wrote:
>> On Mon, 20 Dec 2010 18:22:48 +0100
>> Jakub Hrozek <jhrozek at redhat.com> wrote:
> 
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> On 12/16/2010 02:02 AM, Simo Sorce wrote:
>>>>
>>>> This command will delete a replication agreement unless it is the
>>>> last one on either server. It is used to change replication
>>>> topology without actually removing any single master for the domain
>>>> (the del command must be used if that the intent).
>>>>
>>>> Simo.
>>>>
>>>
>>> Please document the new action in the manpage. As the actions are not
>>> printed when one specifies --help, there's no way to discover it short
>>> of reading the code.
> 
>> I have a separate ticket to add all the changes to the man page.
>> It requires some deep review and I preferred to split it from the rest
>> of the changes.
> 
>> Simo.
> 
> 
> OK, as long as it is tracked I'm fine :-)
> 
> Ack

Actually, sorry, one more thing I noticed. In del_link(), you assign
"type2 = repl2.get_agreement_type(replica1)" but never use type2 again.
Should the next if say "if repl2 and type2 == replication.IPA_REPLICA:"
perhaps?


_______________________________________________
Freeipa-devel mailing list
Freeipa-devel at redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0Q6DgACgkQHsardTLnvCWScACg2StFWJ0Qy6qvjHagyJyR1g1h
Pg0AoMIKX0xpvoYWU8aAtsoPp5+a4/E7
=31Fc
-----END PGP SIGNATURE-----