[Freeipa-devel] [PATCH] jderose 038 Fix ipalib doctest

[Rob Crittenden]

Jason Gerard DeRose wrote:
> This patch fixes doctests in ipalib/__init__.py that were broken by
> Rob's "364 base64-encode binary data..." patch.
> 
> This patch also removes the unneeded use of textui.encode_binary() in
> the textui.print_keyval() method.  repr('cannot print me') will escape
> non-ascii characters using the Python \xHH hexadecimal literal
> notation... so the output will be terminal safe even without base64
> encoding.
> 
> textui.print_keyval() isn't being used at the moment, AFAIK, but it's
> indented for developer-centric debugging type commands where printing
> the repr() is helpful.

Ok, this is essentially identical to my patch "367 fix some encoding 
issues".

I had 2 other changes not included:

1. Remove the assert in encode_binary()
2. I had a fix for the docstrings in the textui class related to the 
value of production. Did you not run into this one?

rob

> 
> 
> P.S.: I think it might have got lost in the shuffle, but could someone
> ack my 037 patch?  With 037 and this patch, all the unit tests should be
> working again.