[Freeipa-devel] [PATCH] jderose 048 Translatable Param.label, Param.doc

Jason Gerard DeRose jderose at redhat.com
Wed Feb 24 10:08:40 UTC 2010


On Tue, 2010-02-23 at 14:39 -0500, John Dennis wrote:
> On 02/19/2010 11:15 AM, Jason Gerard DeRose wrote:
> > This patch:
> >
> > 1. Changes Param.label, Param.doc so they can be either text.Gettext or
> > str instances.  This is transitional till we get any outstanding patches
> > merged in, then they will only allow text.Gettext instances.
> >
> > 2. Adds a docstring to the ipalib/parameters.py module explaining the
> > difference between cli_name, label, and doc.  It also has some style
> > guidelines for the label and doc.
> >
> > 3. Marks all Param.label and Param.doc for translation, does some
> > cleanup to hopefully make things a bit more consistent.
> >
> > 4. Various small changes needed to adjust to Param.label, Param.doc
> > being text.Gettext instances.
> 
> ACK
> 
> Sometime in the near future (it can be part of another patch) I'd like 
> to see the doc for cli_name expanded upon to explain it's only purpose 
> is to provide a name for the command line argument (e.g. --foo) and how 
> this is completely independent of the label used for prompts and 
> displaying a value. Also the text.FixMe class needs some documentation 
> on how we plan on using it to find unstranslated strings.


pushed to master.  thanks for the review.




More information about the Freeipa-devel mailing list