[Freeipa-devel] [PATCH] 399 Include params in Method.output_params

[Jason Gerard DeRose]

On Tue, 2010-03-09 at 16:50 -0500, Rob Crittenden wrote:
> Pavel Zuna wrote:
> > Rob Crittenden wrote:
> >> Method overrides the Command get_output_params() method and only 
> >> returns the object params, not anything defined within the method 
> >> itself. Return
> >> those as well so they are displayed in output. Some care needs to be 
> >> taken to avoid returning duplicate values. In the case of duplicates 
> >> the value in obj.params wins.
> >>
> >> I tested this with the pwpolicy plugin which is a Method and defines 
> >> its own takes_options. I need this to display the priority to the user.
> >>
> >> rob
> >>
> > Applies with minor modifications due to recent gettext patches. 
> > Shouldn't there be a check for 'no_output' when going through 
> > self.obj.params?
> > 
> > Pavel
> 
> Yup, new patch attached, good catch.
> 
> rob

ack.  pushed to master.