[Freeipa-devel] [PATCH] jderose 053 XML-RPC signature change

[Jason Gerard DeRose]

On Fri, 2010-03-26 at 09:22 -0400, John Dennis wrote:
> On 03/26/2010 07:24 AM, Jason Gerard DeRose wrote:
> > This quick patch changes the XML-RPC signature to match the
> > complementary change being made in certmonger.
> >
> > The signature is now:
> >
> >      [args, options]
> >
> > This doesn't yet include the [args, options, extra] change... that is
> > coming in my rpcserver patch once it's done.  But this provides what
> > needed for current IPA<=>  certmonger compatibility.
> 
> NAK
> 
> Is there a reason for the type inconsistency? Why is it a list in one 
> case and a tuple in the other? I realize they'll both operate the same 
> way but the inconsistency is confusing especially if there is no reason 
> to use different type objects (e.g. no need for a mutable sequence).

We use lists and tuples interchangeability.  Tuple are nice because they
aren't mutable and are a bit more efficient in terms of memory use, but
both json.loads() and xmlrpclib.loads() return lists.  My general plan
has been to move to using just lists.

json.dumps() and xmlrpclib.dumps() also treat tuples and lists the
same... both are serialized to a list type.

So there's no type change of any consequence in this patch.