[Freeipa-devel] [PATCH] 001 Clarify the description of --raw and -all

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/29/2010 08:45 PM, Rob Crittenden wrote:
> Jakub Hrozek wrote:
> https://fedorahosted.org/freeipa/ticket/244
> 
> If I understand the code correctly, --all is not really a parameter that
> affects only output, it also causes all attributes to be retrieved from
> the server, so I have adjusted the description just a little.
> 
> --raw now mentions it only affects output.
> 
>> nack, --all only affects output as well.
> 

When I said that it doesn't only affect output, I was referring to this
part of baseldap.py:

if options.get('all', False):
   attrs_list = ['*']
else:
   attrs_list = list(self.obj.default_attributes)

I don't have strong feeling about this, but what I wanted to make clear
in the help message was that it /can/ have performance impact as the
ldap query is different. We can for instance have an object in LDAP that
has attribute containing user avatar binary blob or something like
that..in which case, --all would fetch it from the server, right?

But I agree that for user, this is 'behind the scenes', so I'm not
opposed to changing the string..new patch attached..

	Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzQLiIACgkQHsardTLnvCVdUwCgmpvYvvqs3D6/+vpo/PIhjK1Y
jisAniMyZdwrqWRblqdfTfgEaYdvIpw0
=zREK
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: jhrozek-freeipa-0001-02-Clarify-the-description-of-raw-and-all.patc
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101102/f5e69015/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jhrozek-freeipa-0001-02-Clarify-the-description-of-raw-and-all.patc.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101102/f5e69015/attachment.sig>