[Freeipa-devel] [ PATCH ] lite-server.py failing due to cli.py dependency: import default_encoding_utf8

John Dennis jdennis at redhat.com
Wed Nov 3 15:59:33 UTC 2010


On 11/03/2010 11:37 AM, Rob Crittenden wrote:
>>> Patch is a 1 liner that changes:
>>>
>>> import default_encoding_utf8
>>>
>>> To
>>>
>>> from policycoreutils import default_encoding_utf8
>>>
>>>
>>
>> But this one was not reviewed yet, right?
>
> It was, I'm trying to decide what to do with it.
>
> It would seem that the SELinux policycoreutils python package has an
> identically named shared library that seems to do the same thing. I'm
> checking with them to see if that is true, then we can decide if we want
> to use theirs or ours.

It is most likely identical as I provided the source code to both Dan 
(SELinux) and Rob (IPA).

But I'm not sure I see the problem, we should be importing from our own 
package area, it's fine if there are two (identical for the moment) 
modules because they are in their own name space.

Bottom line, we should be importing default_encoding_utf8 from *our* ipa 
package space, not from some other random area where there just happens 
to be an identically named module by coincidence.

-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the Freeipa-devel mailing list