[Freeipa-devel] [PATCH] freeipa-admiyo-freeipa-0075-Ticket-Expiration.patch
Endi Sukma Dewata
edewata at redhat.com
Sat Nov 6 04:45:35 UTC 2010
On 11/5/2010 6:52 PM, Adam Young wrote:
> Here it is.
ACK-ish.. :)
The error handling on ticket expiration works, but there are some minor
issues:
1. The IPA variable is declared twice.
+var IPA;
var IPA = ( function () {
2. IPA_DEFAULT_JSON_URL should be deleted.
var IPA_DEFAULT_JSON_URL = '/ipa/json';
+ var default_json_url = '/ipa/json';
3. Is it necessary to call hasOwnProperty() in this loop?
Variable "a" is obtained from attribute_members, so
I think the hasOwnProperty() will always return true.
for (var a in attribute_members) {
+ if (attribute_members.hasOwnProperty(a)){
If you could fix this before pushing that would be great. Thanks!
--
Endi S. Dewata
More information about the Freeipa-devel
mailing list