[Freeipa-devel] [PATCH] HBAC Access Time

[Adam Young]

On 11/06/2010 12:53 AM, Endi Sukma Dewata wrote:
> Hi,
>
> Please review the attached patch. Thanks!
>
> https://fedorahosted.org/reviewboard/r/102/
>
> IPA commands now can be defined in these classes:
>  - ipa_command: a single IPA command
>  - ipa_batch_command: a batch command for executing multiple commands
>    on the server side using the new batch plugin
>
> The dialog boxes for adding and removing entries have been refactored:
>  - ipa_dialog: base class for dialog boxes
>  - ipa_adder_dialog: generic adder dialog box
>  - ipa_deleter_dialog: generic deleter dialog box
>  - ipa_association_adder_dialog: adding entity association
>  - ipa_association_deleter_dialog: removing entity association
>
> Dialog boxes for adding/deleting HBAC users, hosts, services, and
> sourcehosts are implemented using the association dialog boxes.
>
> The dialog box for adding access time is implemented using ipa_dialog
> and currently contains only a text field. This will be replaced with a
> custom dialog box in a separate patch.
>
> The dialog box for removing access time is implemented using the
> generic deleter class because it's not an association. Removing multiple
> access times is implemented using batch operations.
>
> New test data files for access times have been added.
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


The Time Dialog needs a format. I couldn't guess a value that  it would 
accept.   The  retry/cancel message is really confusing, too.  Tried 
1200, 12:00 and 1200-1300.

1.  Put in text showing the format.
2.  Validate using a regex
3.  Don't use the standard error handling, show the error inside the 
dialog box that has the time in it.




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20101106/ca5a0a2f/attachment.htm>