[Freeipa-devel] [PATCH] 593 fix group objectclasses on detach

Rob Crittenden rcritten at redhat.com
Thu Nov 18 17:30:17 UTC 2010


Jakub Hrozek wrote:
> On Mon, Nov 01, 2010 at 12:08:36PM -0400, Rob Crittenden wrote:
>> Make sure a detached group has the default list of objectclasses.
>> ipaUniqueId is handled by the new uuid plugin.
>>
>> https://fedorahosted.org/freeipa/ticket/250
>>
>> rob
>
> I haven't fully tested the patch yet, but this caught my attention:
>
>> +        (group_dn, group_attrs) = ldap.get_entry(group_dn)
>> +        is_managed = self.obj.has_objectclass(group_attrs['objectclass'], '')
>
> I think that is_managed is guaranteed to be False in this case, since
> has_objectclass would do:
>
> return '' in group_attrs['objectclass']

Gah! Good catch, that should be mepManagedBy. Can you fix this and 
continue testing?

rob




More information about the Freeipa-devel mailing list