[Freeipa-devel] [PATCH] more style fixes

Simo Sorce ssorce at redhat.com
Tue Oct 5 14:45:18 UTC 2010


On Tue, 05 Oct 2010 08:40:03 -0400
Rob Crittenden <rcritten at redhat.com> wrote:

> Simo Sorce wrote:
> > On Mon, 04 Oct 2010 22:42:02 -0400
> > Rob Crittenden<rcritten at redhat.com>  wrote:
> >
> >> Simo Sorce wrote:
> >>>
> >>> fix style in some more code.
> >>> purely cosmetic again.
> >>>
> >>> Simo.
> >>>
> >>
> >> Shouldn't this contain the __func__ fix as well?
> >
> > I stopped adding __func__ for now as it introduces a lot of
> > warnings. The reason is that __func__ is const char * but the
> > logging function takes a simple char *
> >
> > I need to think a bit what is the best solution, I may add a macro
> > later on that basically replaces the logging function with a version
> > that discards the const.
> >
> > But it is not critical, so I decided to just wait a bit.
> >
> > Simo.
> >
> 
> Ok, ack

pushed to master

Simo.



-- 
Simo Sorce * Red Hat, Inc * New York




More information about the Freeipa-devel mailing list