[Freeipa-devel] [PATCH] Initial gettext support for C tools

[John Dennis]

On 10/11/2010 06:43 PM, Simo Sorce wrote:
> Ok, I've filtered out a few other files/directories. I think the list
> now is correct, but whoever will end up reviewing this patchset
> *please* explicitly ack if you think the list is correct or not (you
> can run the new shiny "make debug" to get the new list of files :)
>
> I also decided to split the patch in 3 separate patches.
> 1. to delete the Makefile that I think was erroneously committed by Adam
> 2. to add C files and to fix install/po/Makefile.in
> 3. to update the .pot and .po files after the changes to the makefile
>
> The third patch is compressed (now approx 80KiB) as fully uncompressed
> it is something monstrous like 1.5MiB ...
>
> Simo.
>

Patch 1:

ACK

Patch 2:

This is what I came up with as differences in the file list (all were 
additions from the previous Makefile.in)

checks/check-ra.py
doc/examples/examples.py
doc/examples/python-api.py
install/share/wsgi.py
ipa-radius-server/plugins/__init__.py
ipa-radius-server/plugins/radiusinstance.py
ipalib/plugins/hbacsvc.py
ipalib/plugins/hbacsvcgroup.py
ipalib/plugins/ping.py
ipalib/plugins/sudocmd.py
ipalib/plugins/sudocmdgroup.py
ipalib/plugins/sudorule.py
ipalib/plugins/whoami.py
ipapython/certmonger.py
ipapython/radius_util.py
ipaserver/install/upgradeinstance.py
daemons/ipa-slapi-plugins/ipa-pwd-extop/ipapwd_common.c
daemons/ipa-slapi-plugins/ipa-pwd-extop/ipapwd_encoding.c
daemons/ipa-slapi-plugins/ipa-pwd-extop/ipapwd_prepost.c
daemons/ipa-slapi-plugins/ipa-version/ipa_repl_version.c
daemons/ipa-slapi-plugins/ipa-pwd-extop/ipapwd.h

The doc directory should be excluded.

We're not shipping radius support so radius files should be excluded too.

I think the other additions are O.K., others should review as well.

The doc and radius inclusions should be fixed to receive ACK, otherwise 
patch looks fine.

Patch 3:

These are the msg stats prior to the patch:

> ipa.pot has 414 messages. There are 17 po translation files.
> bn_IN:    24/414   5.8%  390 po untranslated,    0 missing,  390 untranslated
> de:        0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated
> es:      380/414  91.8%   34 po untranslated,    0 missing,   34 untranslated
> fr:        0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated
> id:      121/414  29.2%  293 po untranslated,    0 missing,  293 untranslated
> he:        0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated
> it:        0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated
> ja:        0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated
> kn:      348/414  84.1%   66 po untranslated,    0 missing,   66 untranslated
> ko:        0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated
> pl:      377/414  91.1%   37 po untranslated,    0 missing,   37 untranslated
> pt:        0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated
> pt_BR:     0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated
> ru:      135/414  32.6%  279 po untranslated,    0 missing,  279 untranslated
> uk:      414/414 100.0%    0 po untranslated,    0 missing,    0 untranslated
> zh_CN:   185/414  44.7%  229 po untranslated,    0 missing,  229 untranslated
> zh_TW:     0/414   0.0%  414 po untranslated,    0 missing,  414 untranslated

These are the msg stats after the patch:

> ipa.pot has 577 messages. There are 17 po translation files.
> bn_IN:    38/577   6.6%  539 po untranslated,    0 missing,  539 untranslated
> de:        0/577   0.0%  577 po untranslated,    0 missing,  577 untranslated
> es:      425/577  73.7%  152 po untranslated,    0 missing,  152 untranslated
> fr:        0/577   0.0%  577 po untranslated,    0 missing,  577 untranslated
> id:      137/577  23.7%  440 po untranslated,    0 missing,  440 untranslated
> he:        0/577   0.0%  577 po untranslated,    0 missing,  577 untranslated
> it:        0/577   0.0%  410 po untranslated,  167 missing,  577 untranslated
> ja:        0/577   0.0%  577 po untranslated,    0 missing,  577 untranslated
> kn:      392/577  67.9%  185 po untranslated,    0 missing,  185 untranslated
> ko:        0/577   0.0%  577 po untranslated,    0 missing,  577 untranslated
> pl:      422/577  73.1%  155 po untranslated,    0 missing,  155 untranslated
> pt:        0/577   0.0%  577 po untranslated,    0 missing,  577 untranslated
> pt_BR:     0/577   0.0%  577 po untranslated,    0 missing,  577 untranslated
> ru:      153/577  26.5%  424 po untranslated,    0 missing,  424 untranslated
> uk:      459/577  79.5%  118 po untranslated,    0 missing,  118 untranslated
> zh_CN:   218/577  37.8%  359 po untranslated,    0 missing,  359 untranslated
> zh_TW:     0/577   0.0%  577 po untranslated,    0 missing,  577 untranslated

The most obvious thing is 167 missing msgid's from the it.po file. It 
looks like it.po got corrupted some how (probably wasn't merged from 
ipa.pot). Could you please check what happened to it.po?

NAK
-- 
John Dennis <jdennis at redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/