[Freeipa-devel] [PATCH] #319 better cope with ntp config files

[Rob Crittenden]

Simo Sorce wrote:
> On Fri, 15 Oct 2010 10:27:59 -0400
> Simo Sorce<ssorce at redhat.com>  wrote:
>
>> Right, thanks for catching this, my python got a bit rusty in the last
>> few months :)
>
> Ok, changed the patch according to your guidelines, and retested.
> Also caught a bug that didn't show up with the previous way I did
> stripping.
>
>>> I'm not sure your loop for srv actually does the right thing. I
>>> wonder if you wanted to set match = 0 within the for loop.
>>
>> Well, according to my testing it does.
>> But I'll re-check.
>
> Re-checked, yes the way I use match is how I intended it, it is useful
> only for the inner for loop.
>
> Testing shows I can correctly match entries with arbitrary spacing now.
>
> Simo.

Works for me, ack.

rob