[Freeipa-devel] [PATCH] 519 make ipactl smarter

[Rob Crittenden]

Adam Young wrote:
> On 08/31/2010 05:32 PM, Rob Crittenden wrote:
>> ipactl was a quickie thing I threw together at the end of v1 and it
>> wasn't all too bright. This tries to fix things up and work around
>> some init script issues.
>>
>> The init scripts returns a 1 both if the service isn't running and if
>> it is not running but there is a pid file lying around. I check for
>> this and make a new return value, 4, to represent stopped.
>>
>> Using this I can better tell what the current state of affairs is and
>> just stop/start those services that are actually running.
>>
>> I added named to the list of services we track.
>>
>> rob
>>
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
> Probably shouldn't be using magic constants. I'd recommend replacing
> them with strings. Other than that, Ack

Well, the magic constants are the same as in initscripts and documented 
in-line so I think its probably ok. This is a pretty small script and 
nothing else uses (or probably will use) the values.

Pushed to master

rob