[Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

[Adam Young]

On 09/09/2010 07:00 PM, Endi Sukma Dewata wrote:
> Hi,
>
> Please review the attached patch. Thanks!
>
> The EntityBuilder has been modified to obtain the pkey value by
> invoking getPKey(). This function can be overriden for different
> entities.
>
> The addOptionsFunction() has been renamed to getOptions() and it
> can be overriden for different entities. Each entity that uses this
> function has been modified accordingly.
>
> The addEdit(), addAnother(), add_fail() has been moved into the
> EntityBuilder class. The global builders is no longer needed because
> a reference to the builder object can be obtained via enclosure.
>
> The ServiceForms has been modified to take service name and
> hostname and combine them to generate the service principal by
> overriding the getPKey().
>
> --
> Endi S. Dewata
>    
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
ACK, although please add the following error check in add.js line 67ish
  if (response.error){
                         if (response.error.message){
                             alert(response.error.message);
                         }else{
                             alert("error adding entry");
                         }
                         return;
                     }



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20100909/1ddf042d/attachment.htm>