[Freeipa-devel] [PATCH]admiyo-freeipa-0041-self-service.patch

[Endi Sukma Dewata]

----- "Adam Young" <ayoung at redhat.com> wrote:

> self-service
>      Selects the site map based on the presence or absense of rolegroups for
>      the current user.  If the user has no rolegroups, UI defaults to 
>      the Details page for that user.

NACK. The window_hashchange() is expecting 2 levels of tabs:

var admin_tabs_lists = [
    ['identity', 'IDENTITY', [
        ['user', 'Users', ipa_entity_setup],
    ]]
];

but the self-service tab is only 1 level:

var self_serv_tabs_lists =
    [['user', 'Users', ipa_entity_setup]];

Currently window_hashchange()will ignore if there's no 2nd level
tabs defined:

for (var i = 0; i < nav_tabs_lists.length; ++i) {
    var t = nav_tabs_lists[i]; // 1st level tab

    // if no 2nd level tabs -> skip
    if (typeof t[2] != 'function' && t[2].length) {
        for (var j = 0; j < t[2].length; ++j) {
            var tt = t[2][j]; // 2nd level tab

There's also a typo on line 44, the variable name should
have been nav_tabs_lists instead of nav_tabs_list. But the
code will still work anyway.

--
Endi S. Dewata