[Freeipa-devel] [PATCH] Refactoring navigation.js.
Endi Sukma Dewata
edewata at redhat.com
Thu Sep 30 21:48:48 UTC 2010
Hi,
Please review the attached patch. Thanks!
The navigation.js has been modified to make it more abstract, i.e.
unaware of entity facets. The nav_update_tabs() has been modified
such that it activates and updates the tabs based on the current
state stored in the URL.
The facets are now handled in entity.js. The ipa_entity_setup() has
been modified to update the facets based on the current state and
cached state.
The navigation.js also has been modified to be more class-like. The
nav_create() has been modified to store the tab configuration and
the tab container in internal variables nav_tabs_lists and
nav_container. The nav_update_tabs() now can be called without any
parameters.
Functions nav_push_state(), nav_get_state(), and nav_remove_state()
have been added to wrap BBQ API. This is to allow unit tests to
replace them with mockup functions to remove dependency on BBQ.
--
Endi S. Dewata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: edewata-freeipa-0013-Refactoring-navigation.js.patch
Type: text/x-patch
Size: 14244 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20100930/2b0d8b2f/attachment.bin>
More information about the Freeipa-devel
mailing list