[Freeipa-devel] [PATCH] 760 don't crash when calculating indirect

[JR Aquino]

On Apr 8, 2011, at 7:32 AM, Rob Crittenden wrote:

Martin Kosek wrote:
On Wed, 2011-03-30 at 10:46 -0400, Rob Crittenden wrote:
Rob Crittenden wrote:
This prevents an internal error when calculating direct vs indirect
membership.

ticket 1133


I accidentally included a change from another patch. Updated patch attached.

rob

I think it is OK. But I would suggest adding some comment to the code -
a reason why we pass the ValueError exception. It may not be
self-explanatory when we return to this code in the future.

Martin

I'm withdrawing this patch. It seems to be covering up for a real problem. JR is doing further investigation.

rob

Yes, I believe I have identified the root cause of the crashes, and I believe they should be addressed by my patch for https://fedorahosted.org/freeipa/ticket/1139

My patch ensures that only the groups for which a member is a part of, will be searched to determine the object's direct or indirect membership.

The only time this should throw an exception after the fix for 1139, should be if the memberOf plugin has failed to provide referential integrity.