[Freeipa-devel] [PATCH] 11 Fix unitialized attributes

Martin Kosek mkosek at redhat.com
Wed Apr 13 11:04:47 UTC 2011


On Mon, 2011-04-11 at 15:07 +0200, Jan Cholasta wrote:
> Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data, 
> ipalib.text.LazyText, ipaserver.install.service.Service and 
> ipaserver.rpcserver.WSGIExecutioner.
> 

NACK. This patch breaks the build.

$ make rpms
[snip]
if [ "" != "yes" ]; then \
	./makeapi --validate; \
fi
Traceback (most recent call last):
  File "./makeapi", line 281, in <module>
    sys.exit(main())
  File "./makeapi", line 259, in main
    api.finalize()
  File "/home/mkosek/freeipa/ipalib/plugable.py", line 574, in finalize
    self.__do_if_not_done('load_plugins')
  File "/home/mkosek/freeipa/ipalib/plugable.py", line 384, in
__do_if_not_done
    getattr(self, name)()
  File "/home/mkosek/freeipa/ipalib/plugable.py", line 526, in
load_plugins
    self.import_plugins('ipalib')
  File "/home/mkosek/freeipa/ipalib/plugable.py", line 564, in
import_plugins
    raise e
AttributeError: locked: cannot set Str.re to None
make: *** [version-update] Error 1


Martin




More information about the Freeipa-devel mailing list