[Freeipa-devel] [PATCH] 11 Fix unitialized attributes

Jan Cholasta jcholast at redhat.com
Thu Apr 14 10:58:47 UTC 2011


On 13.4.2011 15:21, Jan Cholasta wrote:
> On 13.4.2011 13:04, Martin Kosek wrote:
>> On Mon, 2011-04-11 at 15:07 +0200, Jan Cholasta wrote:
>>> Fixed unitialized attributes in ipalib.aci.ACI, ipalib.parameters.Data,
>>> ipalib.text.LazyText, ipaserver.install.service.Service and
>>> ipaserver.rpcserver.WSGIExecutioner.
>>>
>>
>> NACK. This patch breaks the build.
>>
>> $ make rpms
>> [snip]
>> if [ "" != "yes" ]; then \
>> ./makeapi --validate; \
>> fi
>> Traceback (most recent call last):
>> File "./makeapi", line 281, in<module>
>> sys.exit(main())
>> File "./makeapi", line 259, in main
>> api.finalize()
>> File "/home/mkosek/freeipa/ipalib/plugable.py", line 574, in finalize
>> self.__do_if_not_done('load_plugins')
>> File "/home/mkosek/freeipa/ipalib/plugable.py", line 384, in
>> __do_if_not_done
>> getattr(self, name)()
>> File "/home/mkosek/freeipa/ipalib/plugable.py", line 526, in
>> load_plugins
>> self.import_plugins('ipalib')
>> File "/home/mkosek/freeipa/ipalib/plugable.py", line 564, in
>> import_plugins
>> raise e
>> AttributeError: locked: cannot set Str.re to None
>> make: *** [version-update] Error 1
>
> Fixed.

NACK, made a stupid mistake. Should be ok now.

>
>>
>>
>> Martin
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel


-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-11-uninitialized-attributes.patch
Type: text/x-patch
Size: 2490 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110414/842748a3/attachment.bin>


More information about the Freeipa-devel mailing list