[Freeipa-devel] [PATCH] 142 Moved entity builder registration into webui.js.

[Adam Young]

On 04/19/2011 06:50 PM, Endi Sukma Dewata wrote:
> The entity builder registration have been moved into webui.js. This
> allows the WebUI to control which entities will be loaded. For instance,
> the entitlement should be loaded only if the plugin is enabled. This
> is done by checking the metadata.
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
NACK.

I like the concept, but the implementation is too verbose.  Instead:

Leave the factories as the top level object.  For the factory name, say 
'entitle' check that the object is in the metadata.  If not, don't 
create the entity.  Then, when processing the tabs, if the entity does 
not exist, drop the tab from the tab set.  The explicit enumeration of 
entities in webui.js is not necessary, nor is putting every entity's 
factory into its own namespace.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110420/59189e05/attachment.htm>