[Freeipa-devel] [PATCH] 239 Fixed host adder dialog.

[Petr Vobornik]

On 08/09/2011 08:04 PM, Endi Sukma Dewata wrote:
> On 8/9/2011 7:12 AM, Petr Vobornik wrote:
>> NACK
>>
>> "Add and edit" without existing DNS reverse zone don't redirect to
>> edit page.
>>
>> Field 'fqdn' doesn't exist any more so getting fqdn from field in
>> host.js:280 "fqdn: that.get_field('fqdn').save()" isn't functional.
>
> Fixed. Now the fqdn is obtained from the command object.
>
> On 8/8/2011 9:17 PM, Adam Young wrote:
>> The JQuery code drawing the table in the create method is
>> cut-and-paste.. It should be possible to make it look right without
>> redrawing the whole table.
>>
>> These two fields should be put into their own section, which can then
>> be responsible for drawing just the rows responsible for these
>> fields, leaving the default behavior for the other rows.
>
> As discussed, this will be done separately in this ticket:
> https://fedorahosted.org/freeipa/ticket/1394
>

ACK

-- 
Petr Vobornik