[Freeipa-devel] [PATCH 44/44] ticket 1705 - internationalize help topics

Rob Crittenden rcritten at redhat.com
Thu Aug 25 20:14:55 UTC 2011


Alexander Bokovoy wrote:
> On 25.08.2011 00:32, John Dennis wrote:
>> * Wrap each topic description in _()
>>
>> * Replace the use of if 'topic' in dir(module) with the more
>>    Pythonic and efficient getattr(module, 'topic', None)
>>
>> * Make sure to invoke unicode on the value returned from _()
>>    otherwise you'll get a GettextFactory instance, not a string
>>
>> * Clean up trailing whitespace errors
> ACK
>
>

ACK from me too, pushed to master and ipa-2-1




More information about the Freeipa-devel mailing list