[Freeipa-devel] [PATCH] 861 roll back client changes on failed install

Rob Crittenden rcritten at redhat.com
Mon Aug 29 21:49:39 UTC 2011


There are still places where the client installation can fail that can 
cause /etc/sysconfig/network to be restored. I went through a number of 
iterations on restoring this and finally decided that we should just 
call uninstall() and undo everything.

When we do automatic uninstallation I made it to be quiet since the user 
probably doesn't care what the individual steps are.

We had a lot of sys.exit() interspersed in the installer that I replaced 
with print and return to make the code paths easier. I also replaced a 
bunch of magic integer values with constants.

If --force is passed we leave things as they are.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-861-rollback.patch
Type: text/x-patch
Size: 20705 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110829/d0a2b6b0/attachment.bin>


More information about the Freeipa-devel mailing list