[Freeipa-devel] [PATCH] 32-47 #2040, #1515 Refactor UI widgets

[Petr Vobornik]

Attaching patch for unit tests.

Couple of widget tests still fail.

They raise couple questions:

1) Should widget expect that array of values like ['value'] will be 
always passed to update(values) method or the update method should also 
work with simple values like 'value'?

2) Should widget load its own metadata - based on entity and its name or 
it is responsibility of field (current implementation)?

3) Should custom dirty checks, or other boolean checks (validate) always 
return pure boolean value, or is integer also acceptable. Usage of &= or 
|= operators is producing integer values because it actually means 'foo 
= foo & bar' not 'foo = foo && bar'

Also all jsl warnings are fixed and jsl.conf for tests is added.

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0049-Fixed-unit-tests-after-widget-refactoring.patch
Type: text/x-patch
Size: 49723 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20111201/6de5a026/attachment.bin>