[Freeipa-devel] [PATCH] 315 Added commands into metadata.

[Petr Vobornik]

On 12/06/2011 06:38 AM, Endi Sukma Dewata wrote:
> On 11/18/2011 12:27 PM, Endi Sukma Dewata wrote:
>>> Now the methods metadata seem to be a subset of commands metadata, so we
>>> probably can change the UI to use commands metadata and not pull the
>>> methods metadata.
>>
>> I did this change in the updated patch. It seems to be working fine.
>>
>>> In the JSON API itself the parameters are specified as options, so the
>>> order shouldn't matter to the UI. Is there a way to define the execute()
>>> using unordered keywords? I'm trying to avoid changing the method
>>> signature again in the future.
>>
>> I replaced takes_args with takes_options which takes care the ordering
>> problem. I verified the old UI way of calling json_metadata still works.
>
> Updated patch attached.

Web UI - ACK.
Server side - seems fine - I would give it an ACK, but I'm not sure if 
I'm the right person for it.


-- 
Petr Vobornik