[Freeipa-devel] [PATCH] 908 make some fields required

[Rob Crittenden]

Rob Crittenden wrote:
> Endi Sukma Dewata wrote:
>> On 11/28/2011 12:09 PM, Rob Crittenden wrote:
>>> Some attributes in the framework were not marked as required even though
>>> they are in the schema. These are typically computed values and I think
>>> the intention was to not prompt for them. This has the side-effect of
>>> them showing as not required in the UI even though they are.
>>>
>>> Since they all have default values set they won't be prompted for on the
>>> CLI so there won't be any practical changes.
>>
>> This patch fixes the problem with required attributes in DNS Zones and
>> cn, uidNumber, and gidNumber in Users. The UI now shows the required
>> indicators for these attributes. So this patch is ACKed.
>>
>> Some problems mentioned in ticket #2015 are still present:
>>
>> 1. Removing the homeDirectory from a user fails because it's required by
>> posixAccount.
>>
>> 2. Removing the gidNumber from a group fails because it's required by
>> posixGroup.
>>
>> 3. Removing config attributes listed in the ticket generates internal
>> error. I think at least the server should return a proper error message.
>> The required indicator can be hard-coded in the UI if necessary.
>>
>
> I know you acked this already but I went ahead and addressed #1 and #2
> and updated the patch.
>
> For #3 I filed a new ticket, https://fedorahosted.org/freeipa/ticket/2159
>
> rob

ACKed by Endi in IRC, pushed to master.

rob