[Freeipa-devel] [PATCH 56] ticket 2172 - If "make rpms" fails so will the next make

Martin Kosek mkosek at redhat.com
Fri Dec 9 09:07:04 UTC 2011


On Thu, 2011-12-08 at 08:34 +0100, Martin Kosek wrote:
> On Wed, 2011-12-07 at 20:39 -0500, John Dennis wrote:
> > If "make rpms" fails it doesn't clean up the rpmbuild directory it created.
> > The next make-lint will also fail because it finds files under rpmbuild.
> > make-lint is invoked by "make rpms", a vicous cycle.
> > 
> > The patch contains two sets of changes
> > 
> > Include "rpmbuild" in the IGNORE_PATHS list of make-lint.
> > 
> > Fix the Makefile to use $(RPMBUILD) consistently, there were a number
> > of hardcoded uses of "rpmbuild" as a direcotry.
> 
> ACK. Pushed to master, ipa-2-1.
> 
> Martin

John send me a patch to remove old $(RPMBUILD) before it is filled with
new content for rpmbuild (attached). I found it quite useful.

Pushed under one-liner rule.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-old-RPMROOT-contents-before-it-is-used-for-rp.patch
Type: text/x-patch
Size: 668 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20111209/2ed64cfd/attachment.bin>


More information about the Freeipa-devel mailing list