[Freeipa-devel] [PATCH] 056 Added facet tabs coloring

[Petr Vobornik]

On 12/12/2011 09:10 PM, Endi Sukma Dewata wrote:
> On 12/12/2011 12:21 PM, Petr Vobornik wrote:
>> Facet tabs are now colored according to their group.
>>
>> https://fedorahosted.org/freeipa/ticket/1976
>
> This is how it looks:
>
> http://edewata.fedorapeople.org/freeipa/install/ui/#identity=group&navigation=identity&group-facet=default&group-pkey=editors
>
>
> Some issues:
>
> 1. The original code uses different background images for
> active/inactive tabs. I think the mockup in the ticket is also showing
> different backgrounds. The new code uses the same background.
>
Fixed, using the background from mockup - but honestly I don't see much 
difference.

> 2. The color is coming from an image. It might be better to use CSS
> color so we can change/add new colors without changing the image. Low
> priority.

It would be quite interesting combinations of sprite image with parts of 
the background transparent and linear gradient made by CSS style. Not 
sure if it would work, probably yes.

> 3. This is probably not an issue, but the light blue and dark blue may
> look too similar to some people. We can change it later if necessary.
>
Maybe, looks fine to me. I used the colors from Kyle.

4. Also changed padding in facet tab to vertically center the text.

-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pvoborni-0056-1-Added-facet-tabs-coloring.patch
Type: text/x-patch
Size: 5156 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20111213/809e0c51/attachment.bin>