[Freeipa-devel] [PATCH] Added undo for permission rights.

Adam Young ayoung at redhat.com
Tue Feb 1 13:37:07 UTC 2011


On 02/01/2011 12:02 AM, Endi Sukma Dewata wrote:
> On 1/31/2011 8:53 PM, Adam Young wrote:
>> On 01/31/2011 08:48 PM, Endi Sukma Dewata wrote:
>>> https://fedorahosted.org/freeipa/ticket/884
>>
>> NACK
>>
>> is_dirty is broken now on permissions.
>
> Could you describe which one is broken? I tried a number of things on 
> permission and delegation but so far everything seems to be working 
> just fine.


Can't reproduce now what I was seeing, so it is likely it was just the 
product of a tired mind.  Code works well .

>
>> A lot of code is gone from aci.js. Is that intentional?
>
> Yes, the IPA.rights_widget now inherits from IPA.checkboxes_widget 
> which works the same way. The only thing left is custom html generation.
> I added IPA.widget.create_undo() to generate standardized undo butt

ACK
pushed to master




More information about the Freeipa-devel mailing list