[Freeipa-devel] [PATCH] 715 ensure required variables are required

Jan Zelený jzeleny at redhat.com
Mon Feb 14 12:46:52 UTC 2011


Rob Crittenden <rcritten at redhat.com> wrote:
> Yi found a tricky way to remove required attributes that aren't required
> in the schema. The problem was we weren't enforcing parameter.required
> in mods (because it was enforcing that every variable with required be
> provided).
> 
> I added a new check routine that is executed after setattr/addattr does
> its work and verifies that no required parameters get skipped.
> 
> ticket 852
> 
> rob

Looks fine, works as expected. ACK

I'm just not sure whether is is necessary to call the function twice - once on 
self.params and once on self.obj.params (I get the latter one, but I'm not 
sure whether the former one is necessary).

Jan




More information about the Freeipa-devel mailing list