[Freeipa-devel] [PATCH] 2 Fix handling of /etc/hosts

Jan Cholasta jcholast at redhat.com
Tue Feb 15 17:47:00 UTC 2011


D'oh!

Fixed.

Honza

Dne 15.2.2011 18:14, Rob Crittenden napsal(a):
> Jan Cholasta wrote:
>> Fixes handling of empty lines, erroneous lines and comments in
>> /etc/hosts.
>>
>> https://fedorahosted.org/freeipa/ticket/971
>>
>
> nack.
>
> Would using line.rstrip() be better than the conditional checking
> explicitly for \n?
>
> I don't think we can use format this way, isn't it new to python 2.7? I
> think you have to use {0} and {1}. We need to support python 2.6 as well.
>
> rob

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-2-hosts.patch
Type: text/x-patch
Size: 1351 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110215/a1ffee6a/attachment.bin>


More information about the Freeipa-devel mailing list