[Freeipa-devel] [PATCH] 44 Fixes in ipa-join man page

[Jan Zelený]

"David O'Brien" <davido at redhat.com> wrote:
> Jan Zelený wrote:
> > https://fedorahosted.org/freeipa/ticket/784
> > https://fedorahosted.org/freeipa/ticket/786
> > https://fedorahosted.org/freeipa/ticket/787
> > 
> > Jan
> 
> nack
> 
> A few typos and style issues:
> 
> - _("File were to store the keytab information"), _("Keytab File Name") },
> + _("File were to store the keytab information"), _("filename") },
> 
> s/were/where
> I would actually reword it:
> "Specifies where to store keytab information."
> 
> s/kerberos/Kerberos/g
> (unless lowercase is required for some reason.)
> 
> +The hostname of IPA server (FQDN).
> "The hostname of the IPA server (FQDN)."
> 
> Join IPA domain and retrieve a keytab with kerberos credentials.
> "Join an IPA domain and retrieve a keytab using Kerberos credentials."

Ok, here is the second version of the patch. David, not all changes you 
proposed are in the patch, I believe they are out of its scope. If we go this 
way, I think a review should be done for all man pages, so we don't fix just a 
couple of mistakes in this page and leave the same mistakes in other man 
pages.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-freeipa-0044-2-Fixes-in-ipa-join-man-page.patch
Type: text/x-patch
Size: 4384 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110216/c90846de/attachment.bin>