[Freeipa-devel] [PATCH] 47 Validate that the reverse DNS record is correct

[Jan Zeleny]

Adam Tkac <atkac at redhat.com> wrote:
> On Wed, Feb 16, 2011 at 10:53:14AM +0100, Jan Zelený wrote:
> > This patch ensures that PTR records added by FreeIPA are compliant with
> > RFC.
> 
> Nack.
> 
> In my opinion the _ptrrecord_pre_callback should also handle PTR records
> for IPv6 addresses.
> 
> You can check validity of IPv6 PTR record this way (pseudocode):
> 
> zone.replace(.ip6.arpa., '')
> if (len(addr.split('.')) + len(zone.split('.')) != 32)
> 	raise_error
> 
> Regards, Adam

Thanks for the review, I made the changes you suggested. Second patch is in 
attachment.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-freeipa-0047-2-Validate-that-the-reverse-DNS-record-is-correct.patch
Type: text/x-patch
Size: 1593 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110216/606618a3/attachment.bin>