[Freeipa-devel] [PATCH] 059 Use unicode parameters in the host plugin

[Jan Zelený]

Jakub Hrozek <jhrozek at redhat.com> wrote:
> On Thu, Feb 17, 2011 at 11:06:35AM +0100, Jan Zelený wrote:
> > Jan Zelený <jzeleny at redhat.com> wrote:
> > > Jakub Hrozek <jhrozek at redhat.com> wrote:
> > > > While reviewing Rob's latest patch I found out that we didn't convert
> > > > to unicode on couple of places in the host plugin.
> > > 
> > > ack
> > 
> > On a second thoughts - maybe the _get_unicode_reverse_zone isn't
> > necessary at all - is it possible to do this change directly at the
> > get_reverse_zone?
> > 
> > Jan
> 
> attached.
> 
> also removed a line of dead code.

Better, thanks. I'd also like to change the code which is using this function, 
so the conversion doesn't take place twice. On the other hand that would be 
rather big change, which IMO shouldn't occur in RC. I think filing a cleanup 
ticket for this is the best option.

Ack

Jan