[Freeipa-devel] [PATCH] 065 Replace only if old and new have nothing in common

[Rob Crittenden]

Jakub Hrozek wrote:
> Replace only if old and new have nothing in common
>

This has problems when removing the last member. There is no adds, rems 
has a single value (the member being removed). The intersection is 0 so 
force_replace gets set to True and nothing ends up getting done.

I added a len(v) > 0 to this conditional and it seems to work. I also 
added a small test case based on Endi's initial report. I'm getting a 
100% test pass rate.

rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rcrit-740-replace.patch
Type: application/mbox
Size: 8387 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20110223/9d8837ec/attachment.mbox>