[Freeipa-devel] [PATCH] bind-dyndb-ldap: new parameter "timeout"

[Jakub Hrozek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/06/2011 06:23 PM, Adam Tkac wrote:
> Hello,
> 
> attached patch introduces new bind-dyndb-ldap parameter called
> "timeout". It controls timeout of the LDAP queries and by default is
> set to 10 seconds.
> 
> The patch solves https://fedorahosted.org/bind-dyndb-ldap/ticket/3.
> 
> Regards, Adam
> 

The code looks OK but I'm wondering whether it would make more sense to
set it globally using ldap_set_option(LDAP_OPT_NETWORK_TIMEOUT) rather
that for the single ldap_search() call. That way, any other ldap_* calls
and also the LDAP bind operation would be controlled from a single place.

	Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0rH/EACgkQHsardTLnvCXMOwCfS6l4xMnZr+IomhJj0fgUAzvx
f7UAn0yD5YGXJlOZkC6SjWp9YeMIDkyM
=Cw6M
-----END PGP SIGNATURE-----