[Freeipa-devel] [PATCH] Unchecked return value in ipa-getkeytab

Jakub Hrozek jhrozek at redhat.com
Tue Jan 11 11:51:30 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/11/2011 10:57 AM, Martin Kosek wrote:
> On Tue, 2011-01-11 at 10:49 +0100, Martin Kosek wrote:
>> krb5_init_context return value was not checked. This could lead
>> to unhandled error issues.
>>
>> This patch moves the Kerberos context initialization to the
>> branch where it is needed and handles the error value in a way
>> that allows program exit in a standard way deallocating all
>> resources.
>>
>> https://fedorahosted.org/freeipa/ticket/721
>>
> 
> Now I noticed that the tabs are used instead of spaces in the affected
> function. Attaching re-formatted patch to keep it pretty.
> 
> Martin
> 

Ack
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0sREIACgkQHsardTLnvCWNEgCfbspAI2OEOPumENCqG3FvpUwm
WxoAoJT3Uy41SmMeslPBZRtkmOGvcx8N
=YXgO
-----END PGP SIGNATURE-----




More information about the Freeipa-devel mailing list