[Freeipa-devel] [PATCH] bind-dyndb-ldap: Don't leave empty nodes in LDAP after DDNS update

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/12/2011 07:37 AM, Adam Tkac wrote:
> Hello,
> 
> bind-dyndb-ldap currently leaves empty nodes in LDAP when the last
> DNS resource record associated with the node was removed:
> 
> Before DDNS update:
> 
> dn: idnsName=test,idnsName=example.com,ou=dns,dc=example,dc=com
> aRecord: 1.1.1.1
> dNSTTL: 1111
> objectClass: idnsRecord
> idnsName: test
> 
> After DDNS update (removal of "test.example.com A 1.1.1.1" record):
> 
> dn: idnsName=test,idnsName=example.com,ou=dns,dc=example,dc=com
> dNSTTL: 1111
> objectClass: idnsRecord
> idnsName: test
> 
> As you can see this node is empty and useless.
> 
> With the patch the whole node is removed.
> 
> Comments are welcomed.
> 
> Regards, Adam



Nack.

Your prototype for ldap_modify_do() includes 'isc_result_t delete_node',
but the actual implementation expects 'isc_boolean_t delete_node'. I'm
guessing that by coincidence these typedefs are the same primitive type,
but I'd rather they both use isc_boolean_t which is more correct.


Otherwise it looks good to me.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0t78gACgkQeiVVYja6o6M3rQCeI8y2pRMVjfaXJ8atOCByQIE/
CVIAoKIFVdTy0DFe6Du2Q3SsXMGHUV7O
=ZlI/
-----END PGP SIGNATURE-----