[Freeipa-devel] [PATCH] bind-dyndb-ldap: Don't leave empty nodes in LDAP after DDNS update

[Stephen Gallagher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/12/2011 01:25 PM, Adam Tkac wrote:
> On Wed, Jan 12, 2011 at 01:15:36PM -0500, Stephen Gallagher wrote:
>> Nack.
>>
>> Your prototype for ldap_modify_do() includes 'isc_result_t delete_node',
>> but the actual implementation expects 'isc_boolean_t delete_node'. I'm
>> guessing that by coincidence these typedefs are the same primitive type,
>> but I'd rather they both use isc_boolean_t which is more correct.
>>
>> Otherwise it looks good to me.
> 
> Good catch! Fixed patch is attached.
> 
> Regards, Adam
> 

Ack

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0t8owACgkQeiVVYja6o6MMYQCcDkN3rfHWqPFd6EbyaK04HVL/
M10Ani4631Mf21ZPdAqKINf1N7wLCZQ9
=HNiC
-----END PGP SIGNATURE-----