[Freeipa-devel] [PATCH] admiyo-0149-jslint-cleanup

[Adam Young]

On 01/18/2011 10:36 AM, Endi Sukma Dewata wrote:
> On 1/18/2011 10:01 PM, Rob Crittenden wrote:
>>>> After this patch is applied running,
>>>>
>>>> jsl -conf jsl.conf
>>>>
>>>> Will report no errors. Running clean is then a requirement for
>>>> committing patches to the javascript code base
>
>> Should this be done as part of the build process or are we going to make
>> individual developers responsible for running it?

I'm mixed.  We can do a lot of web development without running the 
build, so we are unlikely to see the build failures for minor tweaks, 
and it will add yet another step in to slow down the build.  I vote for 
it being part of the code review process for now.

>
> The tool doesn't produce any artifacts that needs to be included in 
> the distribution. I'd say it should be done by anyone modifying 
> javascript code, but the build process can also run it for reporting 
> purposes.
>