[Freeipa-devel] [PATCH] 039 Delete the whole DNS record with no parameters

[Simo Sorce]

On Thu, 20 Jan 2011 17:27:37 -0500
Dmitri Pal <dpal at redhat.com> wrote:

> Michael Gregg wrote:
> > Jakub Hrozek wrote:
> > Hi,
> >
> > as discussed in https://bugzilla.redhat.com/show_bug.cgi?id=671019
> > to delete a DNS RR one has to remove its record types one by one.
> >
> > This patch modifies the behaviour so that if the user runs
> > dnsrecord-del <zone> <record-name> with no other parameters, the
> > whole record is removed.
> >
> > Alternative solutions might be to expose the internal command that
> > is able to delete the record (although I think it is
> > counterintuitive to have one command to remove record types and one
> > for the whole record) or have a special flag (--del-all?) to remove
> > the whole record.
> >
> > The patch also fixes the unit tests as they didn't reflect all the
> > recent changes.
> 
> > Going with this patch sounds good, but to make sure, I polled
> > several
> people here, and they all seemed to think that having to add a
> --del-all or --del-record flag at the end would be better as it would
> be less prone to failure where admins would accidentally delete a
> entire record because they didn't specify anything after the "<zone>
> <record>"
> 
> > So, maybe we do need a --del-all or --del-record operator.
> 
> Agree.

+1
Someone may simply push enter accidentally while checking what to write
after the command. It would be rather unfortunate.

Simo.


-- 
Simo Sorce * Red Hat, Inc * New York