[Freeipa-devel] [PATCH] 198 Fixed object_name usage.

[Adam Young]

On 07/05/2011 03:22 PM, Endi Sukma Dewata wrote:
> On 7/5/2011 1:45 PM, Adam Young wrote:
>> On 07/05/2011 02:30 PM, Endi Sukma Dewata wrote:
>>> The object_name attribute was used as both an identifier and a
>>> label which sometimes require different values (e.g. hbacrule
>>> vs. HBAC rule). The code that uses object_name as an identifier
>>> has been changed to use the 'name' attribute instead. The values
>>> of the object_name attribute have been fixed to become proper
>>> labels.
>>>
>>> Ticket #1217
>
>> I the strings in the plugins are supposed to be read by people, they
>> should be internationalized. Is there any reason to not surround both
>> object_name and object_name_plural with _( )?
>
> The original values were not internationalized and also sometimes they 
> are used in a message that are not internationalized either. I think 
> internationalizing the server messages should be done in a separate 
> ticket.
>
ACK.  Pushed to master.  Please open a ticket for the I18N of server 
messages